Os copio lo que me han comunicado como requisitos para publicar la actualización de pelisalacarta en el repositorio oficial, para que lo discutamos aquí.
¿Qué opináis?
Esta es la solicitud:
Y esta mi respuestasorry this took so long, been busy with my dissertation and the
necessary relaxation after it.
a few comments;
1) managing favorites.xml is NOT something an add-on should do - in
particular not using regexp for writing xml (parsing is dirty, writing
is outright a nono. you can do whatever you want to your own files
ofc). this is a deal breaker and there's absolutely no way i'd ever
accept it.
2) don't write to the global userdata folder - use
getAddonInfo("profile") to get to your add-on's writable directory.
for instance there's no guarantee you're running as the master user.
3) why are you using the old runplugin(plugins://video/pelisalacarta
..) ? should be runplugin(plugin.video.pelisalacarta)
4) don't use os.getcwd - use getAddonInfo("path"). os.getcwd will
break soon when we ditch the internal python
maintaining this code must be a major pita - i have spent over 1h just
reviewing the changes...
En general creo que es lógico que a medida que el plugin va teniendo más funcionalidad colisione con cosas que hace xbmc, como los favoritos, los subtítulos, las actualizaciones automáticas...Thanks Arne.
You must understand that this plugin is developed by several people, and each one works with his channels. I have developed the core features and write some of the channels, but each member work with his channels on his way.
The maintenance of the plugin is a distributed work, and it doesn't take a lot of individual work. I mantain the core files, and each of the channels is mantained by its authors. There is code of better or worse quality, depending of the experience of the individual team members, but the whole works fine and we are not very strict about this. The objective is to make online content available, and to be fun in the process.
Now i'll try to reply your comments:
1) This feature can be removed, and if it is a problem we can for sure remove the entire channels using it (casttv, animeforos). Please confirm us if this is ok for you, i ask the channel author for the change.
2) Sorry but i am not sure what do you mean with this. I have tested the plugin and we don't write to the global userdata folder, with the exception of the favourites file mentioned before. We find the addon folder using "xbmc.translatePath("special://profile/addon_data/%s" % PLUGIN_ID)" in config.py, but we will change as you request.
3) I never used runplugin command myself, it must be another team member code, but if it is a problem can be changed.
4) Ok, we'll make the change.
Regards,
Jesús
Creo que es mejor dejar en el repositorio una versión del plugin aunque sea incompleta, para conseguir una mayor "audiencia", y distribuir como hasta ahora la versión completa.
Pero lo discutimos entre todos, y decidimos si seguimos adelante o les decimos que no nos interesa
, y de hecho yo sólo tengo claro que funcione en XBMC4XBOX, si no existe la ruta o el archivo no se muestra el apartado, lo más probable es que en Dharma no se muestre nada y no se pueda usar.... En cuanto a lo de runplugin yo tampoco lo uso sólo aparece en CastTV dentro de un patrón para favourites.xml, según el formato que yo tengo en XBMC4XBOX.
